Skip to content

ci: fix Julia 1.6 failure on macOS-latest (ARM64) #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amemya wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ci: fix Julia 1.6 failure on macOS-latest (ARM64) #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43e87a1
feat: Exclude incompatible Julia versions and architectures on macOS …
amemya Feb 2, 2026
6a26a0e
fix: matrix config
amemya Feb 2, 2026
ac92377
fix: x86 seek type mismatch
amemya Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/Tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,23 @@ jobs:
arch:
- x64
- x86
exclude:
# Julia 1.6 doesn't support macOS ARM64 (macos-latest is now ARM64)
- version: '1.6'
os: macOS-latest
Comment on lines +32 to +33
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exclusion completely removes Julia 1.6 testing from macOS. According to the issue description, Julia 1.6 supports x86_64 on macOS - it just doesn't support ARM64.

Consider using an Intel-based macOS runner (like macos-13) for Julia 1.6 instead of excluding it entirely. This would maintain test coverage for Julia 1.6 on macOS while avoiding the ARM64 compatibility issue. For example, you could add macos-13 to the os matrix and use an include to specifically pair Julia 1.6 with macos-13.

Copilot uses AI. Check for mistakes.
# macOS runners are ARM64 only, no x86 support
- os: macOS-latest
arch: x86

steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v1
- uses: codecov/codecov-action@v5
with:
file: lcov.info
files: lcov.info
2 changes: 1 addition & 1 deletion src/sourcesink.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ end


function _seek(source::SndFileSource, offset::Integer, whence::Integer)
new_offset = sf_seek(source.filePtr, offset, whence)
new_offset = sf_seek(source.filePtr, sf_count_t(offset), whence)
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change to add an explicit sf_count_t() type conversion in _seek is not mentioned in the PR description and appears unrelated to fixing the CI failure on macOS ARM64. The PR title and description focus exclusively on fixing the Julia 1.6 macOS CI issue.

If this is a separate bug fix or improvement (possibly related to type stability or compatibility), it should either be:

  1. Mentioned in the PR description and explained, or
  2. Moved to a separate PR

This helps maintain clear, focused changes and makes it easier to track what was changed and why.

Copilot uses AI. Check for mistakes.

if new_offset < 0
error("Could not seek to $(offset) in file")
Expand Down
Loading