-
Notifications
You must be signed in to change notification settings - Fork 82
Add cube and light visibility test models for KHR_node_visibility #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lexaknyazev
merged 2 commits into
KhronosGroup:main
from
aaronfranke:khr_node_visibility
Nov 12, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Normalize EOL for all files that Git considers text files. | ||
| * text=auto eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| This model demonstrates the `KHR_node_visibility` extension and its interaction with `KHR_animation_pointer`. | ||
|
|
||
| - If your implementation shows either of the red cubes, it is not compliant with `KHR_node_visibility`. | ||
|
|
||
| - If your implementation does not have the blue cube hiding and showing every 0.5 seconds, either the animation is not playing, or it does not support using `KHR_animation_pointer` to animate the `KHR_node_visibility` visible property. | ||
|
|
||
| Animated screenshot of the test model in action: | ||
|
|
||
|  |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "accessors": [ | ||
| { "bufferView": 0, "componentType": 5126, "count": 24, "max": [0.5, 0.5, 0.5], "min": [-0.5, -0.5, -0.5], "normalized": false, "type": "VEC3" }, | ||
| { "bufferView": 1, "componentType": 5126, "count": 24, "max": [1.0, 1.0, 1.0], "min": [-1.0, -1.0, -1.0], "normalized": false, "type": "VEC3" }, | ||
| { "bufferView": 2, "componentType": 5121, "count": 36, "max": [23], "min": [0], "normalized": false, "type": "SCALAR" }, | ||
| { "bufferView": 3, "componentType": 5126, "count": 11, "max": [5.0], "min": [0.0], "normalized": false, "type": "SCALAR" }, | ||
| { "bufferView": 4, "componentType": 5121, "count": 11, "max": [1], "min": [0], "normalized": false, "type": "SCALAR" } | ||
| ], | ||
| "animations": [ | ||
| { | ||
| "channels": [{ "sampler": 0, "target": { "extensions": { "KHR_animation_pointer": { "pointer": "/nodes/5/extensions/KHR_node_visibility/visible" } }, "path": "pointer" } }], | ||
| "name": "BlinkingBlueCube", | ||
| "samplers": [{ "input": 3, "interpolation": "STEP", "output": 4 }] | ||
| } | ||
| ], | ||
| "asset": { "copyright": "2025 The Khronos Group", "generator": "Godot Engine v4.6.dev.custom_build", "version": "2.0" }, | ||
| "bufferViews": [ | ||
| { "buffer": 0, "byteLength": 288, "byteStride": 12, "target": 34962 }, | ||
| { "buffer": 0, "byteLength": 288, "byteOffset": 288, "byteStride": 12, "target": 34962 }, | ||
| { "buffer": 0, "byteLength": 36, "byteOffset": 576, "target": 34963 }, | ||
| { "buffer": 0, "byteLength": 44, "byteOffset": 612 }, | ||
| { "buffer": 0, "byteLength": 11, "byteOffset": 656 } | ||
| ], | ||
| "buffers": [{ "byteLength": 667, "uri": "CubeVisibility0.bin" }], | ||
| "extensionsRequired": ["KHR_node_visibility"], | ||
| "extensionsUsed": ["KHR_animation_pointer", "KHR_node_visibility"], | ||
| "materials": [ | ||
| { "pbrMetallicRoughness": { "baseColorFactor": [0.855, 0.0, 0.0, 1.0], "metallicFactor": 0.0, "roughnessFactor": 1.0 } }, | ||
| { "pbrMetallicRoughness": { "baseColorFactor": [0.0, 0.855, 0.0, 1.0], "metallicFactor": 0.0, "roughnessFactor": 1.0 } }, | ||
| { "pbrMetallicRoughness": { "baseColorFactor": [0.0, 0.0, 0.855, 1.0], "metallicFactor": 0.0, "roughnessFactor": 1.0 } } | ||
| ], | ||
| "meshes": [ | ||
| { "primitives": [{ "attributes": { "NORMAL": 1, "POSITION": 0 }, "indices": 2, "material": 0, "mode": 4 }] }, | ||
| { "primitives": [{ "attributes": { "NORMAL": 1, "POSITION": 0 }, "indices": 2, "material": 1, "mode": 4 }] }, | ||
| { "primitives": [{ "attributes": { "NORMAL": 1, "POSITION": 0 }, "indices": 2, "material": 2, "mode": 4 }] } | ||
| ], | ||
| "nodes": [ | ||
| { "children": [1, 4, 5], "name": "CubeVisibility" }, | ||
| { "children": [2], "extensions": { "KHR_node_visibility": { "visible": false } }, "mesh": 0, "name": "InvisibleCube", "translation": [-1.5, 0.0, 0.0] }, | ||
| { "children": [3], "mesh": 0, "name": "ChildOfInvisibleShouldBeInvisible", "translation": [0.0, 1.5, 0.0] }, | ||
| { "mesh": 0, "name": "DescendantOfInvisibleShouldBeInvisible", "translation": [0.0, 1.5, 0.0] }, | ||
| { "mesh": 1, "name": "VisibleCube" }, | ||
| { "extensions": { "KHR_node_visibility": { "visible": true } }, "mesh": 2, "name": "AnimatedVisibility", "translation": [1.5, 0.0, 0.0] } | ||
| ], | ||
| "scene": 0, | ||
| "scenes": [{ "nodes": [0] }] | ||
| } |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "version": 2, | ||
| "legal": [ | ||
| { | ||
| "license": "CC0", | ||
| "licenseUrl": "https://creativecommons.org/publicdomain/zero/1.0/legalcode", | ||
| "artist": "Aaron Franke", | ||
| "year": "2025", | ||
| "owner": "Khronos Group", | ||
| "what": "Everything", | ||
| "text": "CC0 1.0 Universal", | ||
| "spdx": "CC0-1.0", | ||
| "icon": "https://licensebuttons.net/p/zero/1.0/88x31.png" | ||
| } | ||
| ], | ||
| "tags": [ | ||
| "testing" | ||
| ], | ||
| "screenshot": "screenshot/screenshot_animated.webp", | ||
| "name": "Cube Visiblity test for KHR_node_visibility", | ||
| "path": "./Models/CubeVisibility", | ||
| "summary": "This model demonstrates the `KHR_node_visibility` extension and its interaction with `KHR_animation_pointer`.", | ||
| "createReadme": true | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| This model demonstrates the `KHR_node_visibility` extension and its interaction with `KHR_animation_pointer`. | ||
|
|
||
| - If your implementation shows either of the red spotlights, it is not compliant with `KHR_node_visibility`. | ||
|
|
||
| - If your implementation does not have the blue spotlight hiding and showing every 0.5 seconds, either the animation is not playing, or it does not support using `KHR_animation_pointer` to animate the `KHR_node_visibility` visible property. | ||
|
|
||
| Animated screenshot of the test model in action: | ||
|
|
||
|  |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| "accessors": [ | ||
| { "bufferView": 0, "componentType": 5126, "count": 4, "max": [3.0, 1.5, 0.0], "min": [-3.0, -1.5, 0.0], "normalized": false, "type": "VEC3" }, | ||
| { | ||
| "bufferView": 1, | ||
| "componentType": 5126, | ||
| "count": 4, | ||
| "max": [-1.5259254723787308e-5, -1.5259254723787308e-5, 1.0], | ||
| "min": [-1.5259254723787308e-5, -1.5259254723787308e-5, 1.0], | ||
| "normalized": false, | ||
| "type": "VEC3" | ||
| }, | ||
| { "bufferView": 2, "componentType": 5121, "count": 6, "max": [3], "min": [0], "normalized": false, "type": "SCALAR" }, | ||
| { "bufferView": 3, "componentType": 5126, "count": 11, "max": [5.0], "min": [0.0], "normalized": false, "type": "SCALAR" }, | ||
| { "bufferView": 4, "componentType": 5121, "count": 11, "max": [1], "min": [0], "normalized": false, "type": "SCALAR" } | ||
| ], | ||
| "animations": [ | ||
| { | ||
| "channels": [{ "sampler": 0, "target": { "extensions": { "KHR_animation_pointer": { "pointer": "/nodes/5/extensions/KHR_node_visibility/visible" } }, "path": "pointer" } }], | ||
| "name": "BlinkingBlueLight", | ||
| "samplers": [{ "input": 3, "interpolation": "STEP", "output": 4 }] | ||
| } | ||
| ], | ||
| "asset": { "copyright": "2025 The Khronos Group", "generator": "Godot Engine v4.6.dev.custom_build", "version": "2.0" }, | ||
| "bufferViews": [ | ||
| { "buffer": 0, "byteLength": 48, "byteStride": 12, "target": 34962 }, | ||
| { "buffer": 0, "byteLength": 48, "byteOffset": 48, "byteStride": 12, "target": 34962 }, | ||
| { "buffer": 0, "byteLength": 6, "byteOffset": 96, "target": 34963 }, | ||
| { "buffer": 0, "byteLength": 44, "byteOffset": 104 }, | ||
| { "buffer": 0, "byteLength": 11, "byteOffset": 148 } | ||
| ], | ||
| "buffers": [{ "byteLength": 159, "uri": "LightVisibility0.bin" }], | ||
| "extensions": { | ||
| "KHR_lights_punctual": { | ||
| "lights": [ | ||
| { "color": [1.0, 0.0, 0.0], "intensity": 5.0, "range": 5.0, "spot": { "innerConeAngle": 0.65, "outerConeAngle": 0.8 }, "type": "spot" }, | ||
| { "color": [0.0, 1.0, 0.0], "intensity": 5.0, "range": 5.0, "spot": { "innerConeAngle": 0.65, "outerConeAngle": 0.8 }, "type": "spot" }, | ||
| { "color": [0.0, 0.125, 1.0], "intensity": 6.0, "range": 5.0, "spot": { "innerConeAngle": 0.65, "outerConeAngle": 0.8 }, "type": "spot" } | ||
| ] | ||
| } | ||
| }, | ||
| "extensionsRequired": ["KHR_lights_punctual", "KHR_node_visibility"], | ||
| "extensionsUsed": ["KHR_animation_pointer", "KHR_lights_punctual", "KHR_node_visibility"], | ||
| "meshes": [{ "primitives": [{ "attributes": { "NORMAL": 1, "POSITION": 0 }, "indices": 2, "mode": 4 }] }], | ||
| "nodes": [ | ||
| { "children": [1, 4, 5, 6], "name": "LightVisibility" }, | ||
| { "children": [2], "extensions": { "KHR_lights_punctual": { "light": 0 }, "KHR_node_visibility": { "visible": false } }, "name": "InvisibleLight", "translation": [-1.5, 0.0, 1.0] }, | ||
| { "children": [3], "extensions": { "KHR_lights_punctual": { "light": 0 } }, "name": "ChildOfInvisibleShouldBeInvisible" }, | ||
| { "extensions": { "KHR_lights_punctual": { "light": 0 } }, "name": "DescendantOfInvisibleShouldBeInvisible" }, | ||
| { "extensions": { "KHR_lights_punctual": { "light": 1 } }, "name": "VisibleLight", "translation": [0.0, 0.0, 1.0] }, | ||
| { "extensions": { "KHR_lights_punctual": { "light": 2 }, "KHR_node_visibility": { "visible": true } }, "name": "AnimatedVisibility", "translation": [1.5, 0.0, 1.0] }, | ||
| { "mesh": 0, "name": "QuadMeshNode" } | ||
| ], | ||
| "scene": 0, | ||
| "scenes": [{ "nodes": [0] }] | ||
| } |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "version": 2, | ||
| "legal": [ | ||
| { | ||
| "license": "CC0", | ||
| "licenseUrl": "https://creativecommons.org/publicdomain/zero/1.0/legalcode", | ||
| "artist": "Aaron Franke", | ||
| "year": "2025", | ||
| "owner": "Khronos Group", | ||
| "what": "Everything", | ||
| "text": "CC0 1.0 Universal", | ||
| "spdx": "CC0-1.0", | ||
| "icon": "https://licensebuttons.net/p/zero/1.0/88x31.png" | ||
| } | ||
| ], | ||
| "tags": [ | ||
| "testing" | ||
| ], | ||
| "screenshot": "screenshot/screenshot_animated.webp", | ||
| "name": "Light Visiblity test for KHR_node_visibility", | ||
| "path": "./Models/LightVisibility", | ||
| "summary": "This model demonstrates the `KHR_node_visibility` extension and its interaction with `KHR_animation_pointer`.", | ||
| "createReadme": true | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.