Add cube and light visibility test models for KHR_node_visibility#235
Add cube and light visibility test models for KHR_node_visibility#235lexaknyazev merged 2 commits intoKhronosGroup:mainfrom
Conversation
This change fixes an issue with the [sample asset for KHR_mesh_visibility](KhronosGroup/glTF-Sample-Assets#235) not working. I'm not adding a test for this asset yet as this sample asset is not conformant with the extension spec yet. It also moves the visible properties from `AbstractMesh` to `Node` which fixes some issues with how visibility is being handled. The inspector v2 has also been updated to match this change.
8581945 to
308b656
Compare
eaa65d0 to
8f754b2
Compare
lexaknyazev
left a comment
There was a problem hiding this comment.
Consider not updating LICENSE.md, README.md, Models*.md, and model-index.json files as they should be regenerated by bots anyway.
8f754b2 to
fc35363
Compare
|
Fixed those issues.
The PR has to include updating these files, because otherwise the CI will complain about them not being updated. |
I'm not seeing any failed build here - am I overlooking something? Only the |
|
@javagl I was getting CI failures when I first opened the PR: https://github.com/KhronosGroup/glTF-Sample-Assets/actions/runs/18479060875/job/52649972324 So I ran all the CI stuff locally to get the asset fully fixed. I have not actually tested if the CI shows a failure with some of these changes are excluded, but I'm confused as to what the point would be if these changes will be made anyway. |
The idea is that only the (The amount of work that people are putting into things like https://github.com/cx20/gltf-test is astonishing - but imagine how much harder that would be if everbody could just check in arbitrary files can call them "sample assets"...) The build failure (that refers to the state from https://github.com/KhronosGroup/glTF-Sample-Assets/tree/741e2185b5d82991cfbde5fe5ab3ca50f9c9ceda/Models/CubeVisibility ) was caused by the facts that...
|
fc35363 to
5d933c3
Compare
5d933c3 to
343c36a
Compare
Same as PR KhronosGroup/glTF-Test-Assets-Interactivity#3, I was told to make a PR to both repos, because this is interactivity-related and interactivity implementers will need this, but also this makes sense outside of interactivity.
This model demonstrates the
KHR_node_visibilityextension and its interaction withKHR_animation_pointer.If your implementation shows either of the red cubes, it is not compliant with
KHR_node_visibility.If your implementation does not have the blue cube hiding and showing every 0.5 seconds, either the animation is not playing, or it does not support using
KHR_animation_pointerto animate theKHR_node_visibilityvisible property.Animated screenshot of the test model in action:
The other model demonstrates the same but with lights.
If your implementation shows either of the red spotlights, it is not compliant with
KHR_node_visibility.If your implementation does not have the blue spotlight hiding and showing every 0.5 seconds, either the animation is not playing, or it does not support using
KHR_animation_pointerto animate theKHR_node_visibilityvisible property.Note: These 6 Godot PRs are required to fully fix this test asset in Godot:
STEPinterpolation for integer and boolean animations godotengine/godot#111615