Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An asset for testing the
KHR_node_visibilityextension.A first version of this was posted in a comment in the pull request. A version with minor additions was posted in a later comment. It could make sense to add this as a dedicated test asset for the extension here.
The asset uses some nested node structure to display the messages and support status. A summary:
First row:
visible:false. So when the extension is supported, this is not shown.Second row:
visible:undefined, which should default totrue. So when the default is handled properly, then this is shown.Third row:
false, false, trueandtrue, true, false, respectively.(There are some blank rectangles that hide the implementation messages when the extension is not supported at all).
Direct preview to the README body: https://github.com/javagl/glTF-Sample-Assets/blob/add-node-visibility-test/Models/NodeVisibilityTest/README.body.md