Skip to content

Conversation

@vagisha
Copy link
Collaborator

@vagisha vagisha commented Feb 5, 2025

Rationale

When a Skyline document is moved to another folder, FilePathRoot on the moved ExpRun continues to point to the source container.

  • FilePathRoot gets set incorrectly in XarReader:
    vals.setFilePathRoot(FileUtil.getAbsolutePath(_xarSource.getRootPath()))
  • getRootPath() method in MoveRunsXarSource returns the root path in the source container.
  • Incorrect FilePathRoot causes the PanoramaPublic data copy pipeline to fail in PanoramaPublicFileImporter.alignDataFileUrls()

Related issues and tickets:

Related Pull Requests

Changes

  • Test:
    • Move Skyline documents from other folders into a folder that will be submitted to Panorama Public
    • Verify the FilePathRoot on the moved runs
    • Verify that the folder is successfully copied to Panorama Public

@labkey-jeckels labkey-jeckels merged commit 3e81970 into release24.11-SNAPSHOT Feb 18, 2025
1 check passed
@labkey-jeckels labkey-jeckels deleted the 24.11_fb_fix-filepathroot-on-move-run branch February 18, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants