Fix pipeline job failure when moving Skyline documents in folders with non-ASCII characters #1011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Non-ASCII characters were not getting percent encoded in the dataFileUrl set on the ExpData associated with .skyd files.
As a result, in folder paths that contain non-ASCII characters, two rows were being created in ExpData for a .skyd file. One with un-encoded characters and a second with a fully percent-encoded dataFileUrl.
Example:
This was causing a pipeline job error when moving a Skyline document across folders. It also caused the test added in LabKey/MacCossLabModules#502 to fail, due to the pipeline job error, when running on TeamCity.
NOTE: Path.toUri() has platform specific behavior, it seems. On my Windows machine, Path.toUri() does not percent-encode special characters. As a result, File.toURI() and Path.toUri () end up producing the same percent-encoded values. That is why the move pipeline job and test succeed locally, but fail on TeamCity where File.toURI() and Path.toUri() produce different percent encoding.
Related Pull Requests
Changes