Conversation
…courage use of yarn instead of npm
Add mannequin service
…. Move environment config from docker directory to .env
…lando tooling for importing from pantheon
…ire-agent` is always running.
Blackfire in Lando (alternate approach)
rbayliss
left a comment
rbayliss
left a comment
There was a problem hiding this comment.
Some comments below. The big one is the rename of the .env directory to .lando (or something else). In general, this PR takes us halfway - it gets Lando set up for local development, but still runs docker-compose in CircleCI. That's ok - I think it'd be fine to figure out Lando in circle as a future step.
| @@ -12,7 +12,7 @@ Refresh your local environment from Pantheon. | |||
| Options: | |||
There was a problem hiding this comment.
Is this file needed anymore? We can just use lando pull now, right?
| # * TERMINUS_MACHINE_TOKEN | ||
| # | ||
| # It also depends on the following environment variables declared in docker/drupal.env: | ||
| # It also depends on the following environment variables declared in .env/drupal.env: |
There was a problem hiding this comment.
I don't think we should use .env as a directory, because it prevents us from ever using a .env file. In #111, we discussed moving this into .lando instead.
| # | ||
| # * TERMINUS_SITE | ||
| # * TERMINUS_SOURCE_ENVIRONMENT | ||
| # * TERMINUS_ENV |
There was a problem hiding this comment.
Is there a compelling reason to rename this variable? If not, I'd prefer to leave it as TERMINUS_SOURCE_ENVIRONMENT for backward compatibility reasons.
| @@ -0,0 +1,12 @@ | |||
| <?php | |||
|
|
|||
| $databases['default']['default'] = array ( | |||
There was a problem hiding this comment.
I know these are the lando defaults, but for flexibility, I think we should use this instead:
$lando_info = json_decode(getenv('LANDO_INFO'), TRUE);
$databases['default']['default'] = [
'driver' => 'mysql',
'database' => $lando_info['database']['creds']['database'],
'username' => $lando_info['database']['creds']['user'],
'password' => $lando_info['database']['creds']['password'],
'host' => $lando_info['database']['internal_connection']['host'],
'port' => $lando_info['database']['internal_connection']['port'],
];
This will support changing credentials through Lando.
4 participants
No description provided.