Blackfire in Lando (alternate approach)#111
Merged
jlandfried merged 1 commit intolandofrom May 27, 2020
Merged
Conversation
Contributor
|
Makes sense, yeah I'm a factor of moving |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is another way of running Blackfire in Lando that I think might be more stable. Blackfire actually has 3 parts:
Currently in #109, all 3 are running in the app server. This PR switches things up so that the agent runs in another container, and the probe and CLI are installed on the server. The advantage here is that you don't have to make sure the agent is running on the app server (something that appears to be problematic from the comments).
I'm not actually sure how to configure this with a
.envdirectory, but you just need to make the 4 blackfire environment variables available when lando is started, either by putting them into a .env file or exposing them manually. Also, just a note on that.envdirectory - I found that a bit confusing, since I'd normally have a.envfile, and I can't anymore. If those configurations are meant to be shared, it'd be awesome to move them into the.landodirectory with the other configuration so you can retain a top level.envfile.