[QMS-624] Suspicion: QMS crashes if BRouter RD5 file is missing#629
Closed
kiozen wants to merge 2 commits intoMaproom:devfrom
Closed
[QMS-624] Suspicion: QMS crashes if BRouter RD5 file is missing#629kiozen wants to merge 2 commits intoMaproom:devfrom
kiozen wants to merge 2 commits intoMaproom:devfrom
Conversation
kiozen
force-pushed
the
QMS-624
branch
2 times, most recently
from
0a22213 to
db3b70b
Compare
ntruchsess
suggested changes
Aug 10, 2023
3 tasks
ntruchsess
suggested changes
Aug 11, 2023
Contributor
ntruchsess
left a comment
ntruchsess
left a comment
There was a problem hiding this comment.
looks good, please incorporate my suggested changes of kiozen#1
Collaborator
Author
Done. And now we still need to know why it crashes. |
and mark methods as noexecpt(false)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the linked issue for this pull request:
QMS-#624
What you have done:
Do not forward the exception in
CRouterBRouter::synchronousRequest()Display the error on the canvasSteps to perform a simple smoke test:
Follow the descriptions in the ticket
Does the code comply to the coding rules and naming conventions Coding Guidelines:
Is every user facing string in a tr() macro?
Did you add the ticket number and title into the changelog? Keep the numeric order in each release block.