[QMS-624] fix BRouter mutex threading issues#1
Open
ntruchsess wants to merge 2 commits intokiozen:QMS-624from
Open
[QMS-624] fix BRouter mutex threading issues#1ntruchsess wants to merge 2 commits intokiozen:QMS-624from
ntruchsess wants to merge 2 commits intokiozen:QMS-624from
Conversation
ntruchsess
changed the title
ntruchsess
changed the title
Author
|
@kiozen while this is most likely not causing said crash it should be fixed as you are touching the affected code anyway |
3 tasks
ntruchsess
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the linked issue for this pull request:
QMS-Maproom#624
What you have done:
replaced the mutex-protected field 'synchronous' by a reply-property that doesn't require to be protected as qt takes care when delivering via signal.
Steps to perform a simple smoke test:
[comment]: # N/A, you cannot see the difference in the ui
Does the code comply to the coding rules and naming conventions Coding Guidelines:
Is every user facing string in a tr() macro?
Did you add the ticket number and title into the changelog? Keep the numeric order in each release block.