Skip to content

refactor(ci): validate GitHub event payloads with Pydantic models#987

Merged
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-pydantic-event/I06f75cbee3238d0418560159c2888c70560a1e46
Feb 25, 2026
Merged

refactor(ci): validate GitHub event payloads with Pydantic models#987
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-pydantic-event/I06f75cbee3238d0418560159c2888c70560a1e46

Conversation

@jd
Copy link
Member

@jd jd commented Feb 25, 2026

Replace untyped dict manipulation of GitHub webhook payloads with
Pydantic models, parsing once at the boundary in get_github_event()
and passing typed objects throughout. This removes ~40 lines of manual
isinstance/get checks and catches schema violations early.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

@mergify mergify bot deployed to Mergify Merge Protections February 25, 2026 08:07 Active
@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2026

🧪 CI Insights

Here's what we observed from your CI run for 67492ad.

🟢 All jobs passed!

But CI Insights is watching 👀

@mergify mergify bot requested a review from a team February 25, 2026 08:08
JulianMaurin
JulianMaurin previously approved these changes Feb 25, 2026
sileht
sileht previously approved these changes Feb 25, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2026

Merge Queue Status

Rule: default


This pull request spent 18 seconds in the queue, with no time running CI.

Required conditions to merge

Reason

The pull request #987 has been manually updated

Hint

If you want to requeue this pull request, you can post a @mergifyio queue comment.

@mergify mergify bot added the queued label Feb 25, 2026
Replace untyped dict manipulation of GitHub webhook payloads with
Pydantic models, parsing once at the boundary in get_github_event()
and passing typed objects throughout. This removes ~40 lines of manual
isinstance/get checks and catches schema violations early.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change-Id: I06f75cbee3238d0418560159c2888c70560a1e46
Claude-Session-Id: fbc3e1a8-2cec-43d2-8105-298313058e7a
mergify bot added a commit that referenced this pull request Feb 25, 2026
@jd jd force-pushed the devs/jd/worktree-pydantic-event/I06f75cbee3238d0418560159c2888c70560a1e46 branch from 28a8644 to 67492ad Compare February 25, 2026 10:21
@mergify mergify bot dismissed stale reviews from JulianMaurin and sileht February 25, 2026 10:21

Pull request has been modified.

@mergify mergify bot deployed to Mergify Merge Protections February 25, 2026 10:21 Active
@mergify mergify bot removed the queued label Feb 25, 2026
@mergify mergify bot requested a review from a team February 25, 2026 10:23
@mergify mergify bot requested a review from a team February 25, 2026 10:27
mergify bot added a commit that referenced this pull request Feb 25, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2026

Merge Queue Status

Rule: default


This pull request spent 2 minutes 56 seconds in the queue, including 2 minutes 42 seconds running CI.

Required conditions to merge

@mergify mergify bot added the queued label Feb 25, 2026
@mergify mergify bot merged commit 26b1946 into main Feb 25, 2026
10 checks passed
@mergify mergify bot deleted the devs/jd/worktree-pydantic-event/I06f75cbee3238d0418560159c2888c70560a1e46 branch February 25, 2026 13:03
@mergify mergify bot removed the queued label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants