Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
Author
|
@SocketSecurity ignore npm/@ethereumjs/util@9.1.0
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ccharly
commented
Oct 7, 2025
Comment on lines
+62
to
+64
| "@noble/hashes@^1.1.2": "patch:@noble/hashes@npm%3A1.7.1#./.yarn/patches/@noble-hashes-npm-1.7.1-4106ab26c5.patch", | ||
| "@noble/hashes@^1.3.1": "patch:@noble/hashes@npm%3A1.7.1#./.yarn/patches/@noble-hashes-npm-1.7.1-4106ab26c5.patch", | ||
| "@noble/hashes@^1.3.2": "patch:@noble/hashes@npm%3A1.7.1#./.yarn/patches/@noble-hashes-npm-1.7.1-4106ab26c5.patch" |
Contributor
Author
There was a problem hiding this comment.
We only add the resolutions for the packages that were causing the webpack build issue
danroc
approved these changes
Oct 8, 2025
7 tasks
shane-t
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping all accounts dependencies to the latest so we can start re-using this Snap to do dev testing.
Note
Upgrades MetaMask keyring to v21 with new snap client/sdk, updates imports and account scopes, and adds a Yarn patch for @noble/hashes to resolve crypto in bundlers.
@metamask/keyring-apito^21.0.0and add@metamask/keyring-snap-client(site) and@metamask/keyring-snap-sdk(snap).@noble/hashes@1.7.1and setresolutions; fallback to Nodecryptowhenwebcryptois unavailable in bundlers.packages/site)KeyringSnapRpcClientimport to@metamask/keyring-snap-client.packages/snap)@metamask/keyring-snap-sdkand update types (KeyringEventPayload).scopes: [EthScope.Eoa]to created accounts and make#emitEventgeneric.snap.manifest.jsonsource.shasum.Written by Cursor Bugbot for commit fd8bf57. This will update automatically on new commits. Configure here.