-
-
Notifications
You must be signed in to change notification settings - Fork 22
chore: bump accounts dependencies #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| diff --git a/esm/cryptoNode.js b/esm/cryptoNode.js | ||
| index 4f77e8f46c5e242e1e3cb92712dc65e95a8b8eb0..acd05d884061e18adf27d33ba4a1c55e9cc85e7f 100644 | ||
| --- a/esm/cryptoNode.js | ||
| +++ b/esm/cryptoNode.js | ||
| @@ -7,9 +7,19 @@ | ||
| */ | ||
| // @ts-ignore | ||
| import * as nc from 'node:crypto'; | ||
| -export const crypto = nc && typeof nc === 'object' && 'webcrypto' in nc | ||
| - ? nc.webcrypto | ||
| - : nc && typeof nc === 'object' && 'randomBytes' in nc | ||
| +// It seems `webpack` is not able to resolve `nc.webcrypto` at build time. Probably because | ||
| +// we use `crypto-browserify` under the hood, and this package does not expose `webcrypto`. | ||
| +// While this work when using `require` imports, it seems to fail with ESM exports (at least | ||
| +// in this case). | ||
| +// export const crypto = nc && typeof nc === 'object' && 'webcrypto' in nc | ||
| +// ? nc.webcrypto | ||
| +// : nc && typeof nc === 'object' && 'randomBytes' in nc | ||
| +// ? nc | ||
| +// : undefined; | ||
| + | ||
| +// We just fallback to the "normal crypto" object to workaround this. | ||
| +export const crypto = | ||
| + nc && typeof nc === 'object' && 'randomBytes' in nc | ||
| ? nc | ||
| : undefined; | ||
| //# sourceMappingURL=cryptoNode.js.map |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only add the resolutions for the packages that were causing the
webpackbuild issue