Adds a method to remove an existing video capture device.#36
Closed
dsmurfin wants to merge 2 commits intoMetalPetal:masterfrom
Closed
Adds a method to remove an existing video capture device.#36dsmurfin wants to merge 2 commits intoMetalPetal:masterfrom
dsmurfin wants to merge 2 commits intoMetalPetal:masterfrom
Conversation
YuAo
force-pushed
the
Remove-Video-Device
branch
from
7097d03 to
e55424f
Compare
YuAo
reviewed
Mar 15, 2022
| public func removeVideoCaptureDevice() { | ||
| self.captureSession.beginConfiguration() | ||
|
|
||
| if let currentVideoDeviceInput = self.videoDeviceInput { |
Member
There was a problem hiding this comment.
It's better to use guard let to only call the beginConfiguration/commitConfiguration when we do have a video device input.
Member
|
Can you describe the situation in which you'd like to remove the video device input? |
Collaborator
Author
|
Closing in favour of #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.