-
Notifications
You must be signed in to change notification settings - Fork 48
refactor: replace string-based activation filters with enum-based system #4592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
daveey
wants to merge
3
commits into
daveey-mines
Choose a base branch
from
daveey-activation-cleanup
base: daveey-mines
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,008
−496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2026
Contributor
Author
This was referenced Jan 3, 2026
This comment has been minimized.
This comment has been minimized.
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
This was referenced Jan 3, 2026
aca44ae to
a45fd31
Compare
This was referenced Jan 4, 2026
a45fd31 to
0f0c196
Compare
0f0c196 to
4f8ee02
Compare
This ensures no-op handlers (like keep_gear) block subsequent handlers. Previously, handlers with empty mutations would return false even when all filters passed, allowing subsequent handlers to execute.
4f8ee02 to
c7fc591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Refactor Activation Handlers and AOE Filters
This PR refactors the activation handler system and AOE effect filtering to use enums instead of string comparisons for better type safety and performance. Key changes include:
TargetTypeenum (Actor, Target, ActorCommons, TargetCommons)members_onlyandignore_membersAOE flags with proper filter configurationsThese changes improve code maintainability and make it easier to create complex filter conditions for both AOE effects and activation handlers.