Fix test-wheel-windows.yml bug and harden CI test-wheel workflows #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all: Fix bug in Windows workflow where pip install used '.' directory instead of wheel files, causing setuptools-scm to build from source in shallow clones and produce invalid fallback versions (0.1.dev...). The bug was noticed because pathfinder was first built with an invalid version number due to the shallow clone, and only then replaced with a wheel in a subsequent step. Changes: - Windows: Change 'pip install .' to 'pip install ./*.whl' to prevent source builds - Linux: Already had the correct pattern, but add --only-binary=:all: - Both workflows: Systematically add --only-binary=:all: to all pip install commands to make intent explicit and guard against accidental source builds This ensures CI tests the exact artifacts that would be distributed.
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
kkraus14
approved these changes
Jan 15, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Windows workflow bug and harden CI workflows with
--only-binary=:all:Fix bug in Windows workflow where pip install used
.directory instead of wheel files, causingsetuptools-scmto build from source in shallow clones and produce invalid fallback versions (0.1.dev...). The bug was noticed because pathfinder was first built with an invalid version number due to the shallow clone, and only then replaced with a wheel in a subsequent step.Changes:
pip install .topip install ./*.whlto prevent source builds--only-binary=:all:--only-binary=:all:to allpip installcommands to make intent explicit and guard against accidental source buildsThis ensures CI tests the exact artifacts that would be distributed.