Skip to content

[19.0][MIG] account_move_tier_validation: Migration to 19.0#3

Open
jguenat wants to merge 42 commits intoOCA:19.0from
jguenat:19.0-mig-account_move_tier_validation
Open

[19.0][MIG] account_move_tier_validation: Migration to 19.0#3
jguenat wants to merge 42 commits intoOCA:19.0from
jguenat:19.0-mig-account_move_tier_validation

Conversation

@jguenat
Copy link
Member

@jguenat jguenat commented Jan 6, 2026

Depends on #1

pegonzalezspesol and others added 30 commits January 6, 2026 12:48
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
* 'Validation In Progress' so as to allow an easy location of the
   invoices for which a validation has been triggered,
   but it is not yet completed.
* 'Validation Not Started' to locate bills that either require
   no validation, or the request for validation has not yet been initiated.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-15.0/account-invoicing-15.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_move_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-15.0/account-invoicing-15.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_move_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/
Currently translated at 100.0% (26 of 26 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/es/
Currently translated at 100.0% (27 of 27 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/sv/
…moves with tier validation

Added tests for changes

Updated error to be checked in tests

Updated error to be checked in tests
Currently translated at 100.0% (28 of 28 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/it/
Edit a new journal entry with lines in currency X different from company currency Y.
Say you have a line of value (amount_currency) N, which is converted to Y(N) (debit/credit).
Then `amount_total` is also N. Because the `readonly="not(review_ids)"` was added, `amount_total` is dirty and sent at save.
Therefore, Odoo uses it and sets the debit/credit values of the lines to N (instead of Y(N), the converted value).
It's as if it's ignoring the currency conversion (note that the values are correct through onchange before the save).

To avoid this, exclude the field from being modified in `get_view`.
@jguenat jguenat force-pushed the 19.0-mig-account_move_tier_validation branch from bb37926 to 44e6948 Compare January 6, 2026 13:39
Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test. The requested by and done by fields are no longer populated.
image
Oopsie, i thank that is handled by the base module :)

@bosd
Copy link

bosd commented Jan 10, 2026

@jguenat Can you please add #1 to the test-requirements.txt for easier testing on a runboat?

@jguenat jguenat force-pushed the 19.0-mig-account_move_tier_validation branch from 1b426e5 to ada9c85 Compare January 13, 2026 17:32
@bosd
Copy link

bosd commented Feb 10, 2026

Functional test: Some errors left

Screencast.From.2026-02-10.11-42-04.mp4

@jguenat Can you please fix this?

@jguenat jguenat force-pushed the 19.0-mig-account_move_tier_validation branch from ada9c85 to 5ba4d6b Compare February 10, 2026 11:12
@bosd
Copy link

bosd commented Feb 10, 2026

Thanks for the quick Fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.