[19.0][MIG] base_tier_validation

[em230418]

No description provided.

[jguenat]

Remove 18.0.X migration scripts

[hieulucky111]

Could you please check again?

[bosd]

orignally posted at #3 but i think it belongs here:

Functional test. The requested by and done by fields are no longer populated.

[em230418]

Functional test. The requested by and done by fields are no longer populated.

Will check that later

[santostelmo]

@jguenat Your change request seems to be resolved. Can you please check again ?

[santostelmo]

@em230418 do you have a moment to check this point ?
#1 (comment)

[LoisRForgeFlow]

Could you include the recent patches done in 18.0?

• OCA/server-ux#1199
• OCA/server-ux#1199

[bosd]

Just noticed a new feature.

Steps to reproduce:
Ask for a tier validation..
First approver rejects.
The user asking for the approval, now sees in the top bar "-1" notification.

[bosd]

Functional review:

Issue: Sequential approval notifications sent to all followers instead of only the pending reviewer

When using approve_sequence=True with notify_on_create=False and notify_on_pending=True, the sequential notification logic correctly
transitions only the first review to "pending" status. However, the actual notification reaches all followers of the record, not just the
intended reviewer.

The issue is in _notify_review_available() in tier_validation.py:

  def _notify_review_available(self, tier_reviews):                                                                                         
      ...                                                                                                                                   
      rec.message_subscribe(                                                                                                                
          partner_ids=users_to_notify.mapped("partner_id").ids                                                                              
      )                                                                                                                                     
      rec.message_post(                                                                                                                     
          subtype_xmlid=self._get_requested_notification_subtype(),                                                                         
          body=rec._notify_requested_review_body(),                                                                                         
      )                                                                                                                                     

message_subscribe() is called without subtype_ids (subscribing with all default subtypes), and then message_post() sends a notification to
all followers of the record — not just the reviewer whose tier just became pending.

This means if the second approver is already a follower (e.g. they created the record, or were auto-subscribed), they receive the
notification at the same time as the first approver, defeating the purpose of sequential approval.

Expected behavior: Only the reviewer whose tier transitions to "pending" should be notified. The second reviewer should only be notified
after the first reviewer approves.

Possible fix: Use a targeted notification (e.g. message_notify()) instead of message_post(), so that only the specific reviewer is
notified rather than all followers.