fix: close zip file handle before saving bundle.zip#357
Merged
najuna-brian merged 2 commits intoOpenDataEnsemble:devfrom Feb 25, 2026
Merged
fix: close zip file handle before saving bundle.zip#357najuna-brian merged 2 commits intoOpenDataEnsemble:devfrom
najuna-brian merged 2 commits intoOpenDataEnsemble:devfrom
Conversation
Mishael-2584
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Close zip file handle before saving bundle.zip
Problem
The
/app-bundle/download-zipendpoint returns 404 when mobile apps try to download app bundles. Thebundle.zipfile is not being saved during bundle upload.Closes #356
Root Cause
In
PushBundle,defer zipFile.Close()keeps the zip file handle open when copying the temp file tobundle.zip. The open handle blocks the copy, causing it to fail silently, sobundle.zipis never created.Solution
defer zipFile.Close()at line 42zipFile.Close()at line 127, before savingbundle.zipThis ensures the zip file handle is closed before copying, allowing
bundle.zipto be saved successfully.Changes
pkg/appbundle/versioning.go: Close zip file handle explicitly before saving bundle.zipTesting
bundle.zipis now successfully created in version directoriesImpact