Skip to content

fix: close zip file handle before saving bundle.zip #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
najuna-brian merged 2 commits into from
Feb 25, 2026
Merged

fix: close zip file handle before saving bundle.zip #357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a50dbaf
fix: close zip file handle before saving bundle.zip
najuna-brian Feb 25, 2026
74dd17e
Merge branch 'dev' into fix/bundle-zip-save-issue
najuna-brian Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion synkronus/pkg/appbundle/versioning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func (s *Service) PushBundle(ctx context.Context, zipReader io.Reader) (*Manifes
if err != nil {
return nil, fmt.Errorf("failed to open zip file: %w", err)
}
defer zipFile.Close()
// Note: We'll close zipFile explicitly before copying tempZipFile to bundle.zip

// Validate the bundle structure
if err := s.validateBundleStructure(&zipFile.Reader); err != nil {
Expand Down Expand Up @@ -123,6 +123,9 @@ func (s *Service) PushBundle(ctx context.Context, zipReader io.Reader) (*Manifes
dstFile.Close()
}

// Close the zip reader before copying the temp file
zipFile.Close()

// Save the original zip to the version directory for direct download
if _, err := tempZipFile.Seek(0, 0); err != nil {
return nil, fmt.Errorf("failed to rewind zip for saving: %w", err)
Expand Down
Loading