test: timezone information was dropped when parsing the cancel NotifyEnd#261
Merged
epmog merged 1 commit intoOpenJobDescription:mainlinefrom Aug 21, 2025
Merged
Conversation
lucaseck
previously approved these changes
Aug 21, 2025
Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
2092846 to
ecddafb
Compare
|
marofke
approved these changes
Aug 21, 2025
lucaseck
approved these changes
Aug 21, 2025
mwiebe
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What was the problem/requirement? (What/Why)
1 test was failing locally for me on my macOS machine -
test_cancel_notify.hint: 18000seconds is 5 hours or GMT-5
At first i thought there was some nuance in datetimes on macOS vs. other OSes. But it turns out that this fails on Windows too if the timezone for the machine isn't UTC.
What was the solution? (How)
We were dropping the timezone information ('Z') from the cancel notify file and so python was interpreting it as the local time before then changing to UTC. Didn't discover this previously since all of our runners are on UTC.
What is the impact of this change?
All non-cross-user tests run locally on macOS (and other OSes if you're not in UTC)!
How was this change tested?
Was this change documented?
N/A
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.