Skip to content

test: timezone information was dropped when parsing the cancel NotifyEnd #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epmog merged 1 commit into from
Aug 21, 2025
Merged

test: timezone information was dropped when parsing the cancel NotifyEnd #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/openjd/sessions/test_runner_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,8 +862,9 @@ def test_cancel_notify(
assert len(notification_data) == 1
assert "NotifyEnd" in notification_data
assert notification_data["NotifyEnd"][-1] == "Z"
time_end = datetime.fromisoformat(notification_data["NotifyEnd"][:-1]).astimezone(
timezone.utc
# Stripping the Z removes timezone information. Need to ensure it's not interpreted as local
time_end = datetime.fromisoformat(notification_data["NotifyEnd"][:-1]).replace(
tzinfo=timezone.utc
)
# Timestamp should be around 2s from cancel signal, but give a 1s window
# for timing differences.
Expand Down