Skip to content

Fix smart speakers not covered by 'Allow all media players' audit setting#381

Merged
tvancott42 merged 1 commit intodevfrom
bugfix/smart-speaker-audit
Feb 28, 2026
Merged

Fix smart speakers not covered by 'Allow all media players' audit setting#381
tvancott42 merged 1 commit intodevfrom
bugfix/smart-speaker-audit

Conversation

@tvancott42
Copy link
Collaborator

@tvancott42 tvancott42 commented Feb 28, 2026

Fixes #378

Summary

  • Smart speakers (Google Home, Amazon Echo, Sonos, etc.) are now covered by the "Allow all media players on main network" audit setting
  • Previously only Apple HomePods could be suppressed (via the Apple streaming setting) - all other smart speakers always generated a VLAN placement warning regardless of settings
  • Updated settings gear metadata to point to media players setting instead of streaming devices

Test plan

  • Existing tests pass (35/35 in DeviceAllowanceSettingsTests)
  • New test: IsSmartSpeakerAllowed_AllowMediaPlayers_ReturnsTrue_ForAnyVendor
  • Zero build warnings
  • Deploy and verify: enable "Allow all media players", run audit, confirm smart speakers show as Informational (not Recommended)

Smart speakers (Google Home, Amazon Echo, Sonos, etc.) are now covered by
the AllowMediaPlayersOnMainNetwork setting. Previously only Apple HomePods
were suppressible via AllowAppleStreamingOnMainNetwork.
@tvancott42 tvancott42 merged commit 7c94434 into dev Feb 28, 2026
@tvancott42 tvancott42 deleted the bugfix/smart-speaker-audit branch February 28, 2026 23:06
@tvancott42 tvancott42 mentioned this pull request Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant