Skip to content

Revert "Fix build error"#3732

Merged
acicovic merged 1 commit intodevelopfrom
revert-3731-fix/build-error
Oct 2, 2025
Merged

Revert "Fix build error"#3732
acicovic merged 1 commit intodevelopfrom
revert-3731-fix/build-error

Conversation

@acicovic
Copy link
Collaborator

@acicovic acicovic commented Oct 2, 2025

Reverts #3731

Summary by CodeRabbit

  • Refactor

    • Streamlined internal API request configuration to improve type safety and consistency. This change enhances reliability and readability without altering existing behavior or user workflows.
  • Chores

    • Applied maintenance updates to align with current typing conventions across related code paths, supporting long-term maintainability and reducing potential future integration friction. No user-facing impact; all features continue to function as before.

@acicovic acicovic added this to the 3.20.8 milestone Oct 2, 2025
@acicovic acicovic self-assigned this Oct 2, 2025
@acicovic acicovic requested a review from a team as a code owner October 2, 2025 13:46
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

📝 Walkthrough

Walkthrough

Replaces an apiFetch call in src/content-helper/common/providers/base-provider.tsx to pass the parse flag via a type cast (APIFetchOptions) instead of object spread with parse: true. No changes to control flow, return types, or exported/public declarations.

Changes

Cohort / File(s) Summary
apiFetch parse typing adjustment
src/content-helper/common/providers/base-provider.tsx
Switches apiFetch invocation from { ...options, parse: true } to options as APIFetchOptions<true>, altering how the parse flag is supplied via typing rather than explicit object merge.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Fix build error #3731 — Modifies the same apiFetch call to change how parse: true is provided, indicating a directly related approach to handling the parse flag.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description only states “Reverts #3731” and does not follow the repository’s template, missing the required Description, Motivation and context, and How has this been tested sections. Please update the PR description to follow the repository template by adding a detailed Description section that outlines the code changes, a Motivation and context section explaining why this revert is necessary, and a How has this been tested section describing your testing process. Including any relevant screenshots if appropriate will help reviewers understand the changes and their impact. Ensuring these sections are complete will streamline the review and approval process.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly indicates that this PR reverts the previous “Fix build error” commit and aligns with the overall intent to revert PR #3731, providing a concise summary of the primary change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-3731-fix/build-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 139e9ec and 330e98f.

⛔ Files ignored due to path filters (8)
  • build/admin-settings.asset.php is excluded by !build/**
  • build/admin-settings.js is excluded by !build/**
  • build/content-helper/dashboard-page.asset.php is excluded by !build/**
  • build/content-helper/dashboard-page.js is excluded by !build/**
  • build/content-helper/dashboard-widget.asset.php is excluded by !build/**
  • build/content-helper/dashboard-widget.js is excluded by !build/**
  • build/content-helper/editor-sidebar.asset.php is excluded by !build/**
  • build/content-helper/editor-sidebar.js is excluded by !build/**
📒 Files selected for processing (1)
  • src/content-helper/common/providers/base-provider.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,ts,tsx,jsx}

⚙️ CodeRabbit configuration file

**/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:

  • Review the code to ensure it is well-structured and adheres to best practices.
  • Verify compliance with WordPress coding standards.
  • Ensure the code is well-documented.
  • Check for security vulnerabilities and confirm the code is secure.
  • Optimize the code for performance, removing any unnecessary elements.
  • Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
  • Ensure each line comment concludes with a period.
  • Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
  • Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."

Files:

  • src/content-helper/common/providers/base-provider.tsx
🧬 Code graph analysis (1)
src/content-helper/common/providers/base-provider.tsx (1)
src/content-helper/common/providers/base-wordpress-provider.tsx (1)
  • apiFetch (145-189)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: E2E against WordPress latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant