Fix Sidebar Row Selection Issue in JSONL Viewer #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction management Co-authored-by: Genie <genie@cosine.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the problem where selecting the last row in the sidebar did not display the corresponding row content in the detail view. The key changes made include attaching a unique tag to each SidebarRowView to ensure proper identification and selection. Additionally, the logic now ensures that when the last row is selected, the detail view is updated to reflect this selection accurately. This resolves the issue by keeping the sidebar and detail view in sync.
Original Task: JSONViewer/wje11yqckcqe
Author: Alistair Pullen