Skip to content

Fix Sidebar Row Selection Issue in JSONL Viewer #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pullerz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Sidebar Row Selection Issue in JSONL Viewer #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions JSONViewer/UI/SidebarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ struct SidebarView: View {
ForEach(filtered, id: \.self) { i in
SidebarRowView(viewModel: viewModel, id: i)
.id(i)
.tag(i)
.onAppear {
if let last = filtered.last, i == last { isAtBottom = true }
}
Expand All @@ -87,6 +88,7 @@ struct SidebarView: View {
ForEach(0..<viewModel.jsonlRowCount, id: \.self) { i in
SidebarRowView(viewModel: viewModel, id: i)
.id(i)
.tag(i)
.onAppear {
if i == viewModel.jsonlRowCount - 1 { isAtBottom = true }
}
Expand All @@ -103,6 +105,8 @@ struct SidebarView: View {
let shouldPin = viewModel.selectedRowID == lastRowCount - 1
lastRowCount = newCount
if shouldPin && newCount > 0 {
// Also move the selection to the new last row so the detail view matches what's shown at bottom.
viewModel.selectedRowID = newCount - 1
DispatchQueue.main.asyncAfter(deadline: .now() + 0.05) {
withAnimation(.easeInOut(duration: 0.15)) {
proxy.scrollTo(newCount - 1, anchor: .bottom)
Expand Down Expand Up @@ -137,6 +141,7 @@ struct SidebarView: View {
}
.padding(.vertical, 4)
.contentShape(Rectangle())
.tag(row.id)
.onAppear {
if let last = filteredRows.last?.id, row.id == last { isAtBottom = true }
}
Expand Down