fix use-after-free

[Un1q32]

According to clang this causes a UAF because the std::string is destroyed, fixed by declaring the temporary std::string in a different scope.

[BrentDaMage]

static std::string getStoragePath()
{
    // Doing this as a c-string because worst-case, an SDK
    // will return a nullptr instead of an empty string
    std::string path;
    {
        const char* tmp;
#ifdef _WIN32
        tmp = getenv("APPDATA");
        if (tmp)
            path = tmp;
#else
        tmp = getenv("XDG_DATA_HOME");
        if (tmp)
            path = tmp;
        else
        {
            tmp = getenv("HOME");
            if (tmp)
                path = std::string(tmp) + "/.local/share";
            else
                LOG_E("HOME not set");
        }
#endif
    }

    if (!path.empty())
        path += "/";
    path += ".reminecraftpe";

    return path;
}

[Un1q32]

done