Skip to content

fix use-after-free #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrentDaMage merged 2 commits into from
Feb 23, 2026
Merged

fix use-after-free #509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b845fad
fix uaf
Un1q32 Feb 22, 2026
5cd7253
redo function
Un1q32 Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions platforms/sdl/sdl1/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,32 +86,26 @@ static void initGraphics()

static std::string getStoragePath()
{
// Doing this as a c-string because worst-case, an SDK
// will return a nullptr instead of an empty string
const char* pathBase;
std::string path;
const char *tmp;
#ifdef _WIN32
pathBase = getenv("APPDATA");
tmp = getenv("APPDATA");
if (tmp)
path = tmp;
#else
const char *xdg_data = getenv("XDG_DATA_HOME");
if (xdg_data)
pathBase = xdg_data;
tmp = getenv("XDG_DATA_HOME");
if (tmp)
path = tmp;
else
{
xdg_data = getenv("HOME");
if (!xdg_data)
{
LOG_E("HOME not set");
pathBase = ""; // current working directory
}
tmp = getenv("HOME");
if (tmp)
path = std::string(tmp) + "/.local/share";
else
pathBase = ((std::string)xdg_data + "/.local/share").c_str();
LOG_E("HOME not set");
}
#endif

if (!pathBase)
pathBase = ""; // just use the current working directory

std::string path(pathBase);
if (!path.empty())
path += "/";
path += ".reminecraftpe";
Expand Down