Conversation
github-actions
bot
added
auto-merge
There was a problem hiding this comment.
Pull request overview
Removes automated “self-healing/apply” workflows and replaces the existing multi-job pipeline with a minimal, deterministic CI workflow.
Changes:
- Deleted the Copilot-driven automation workflow that could mutate branches/branch protections and deploy from comments.
- Replaced the “Comprehensive Pipeline” CI with a single
validatejob that runsnpm ci, lint, typecheck, tests, and build on Node 20 formain.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/copilot-universal-auto.yml | Removes comment-triggered automation that could apply changes, push fixes, deploy, or alter branch protection. |
| .github/workflows/ci.yml | Simplifies CI to a single deterministic validation job on Node 20. |
| @@ -1,557 +1,29 @@ | |||
| name: CI - Comprehensive Pipeline | |||
| name: CI | |||
There was a problem hiding this comment.
The workflow file appears to start with a UTF-8 BOM (invisible character before name). This can cause subtle parsing/tooling issues. Please remove the BOM so the first line begins with plain name: CI.
| name: CI | |
| name: CI |
| if: hashFiles('package.json') != '' | ||
|
|
There was a problem hiding this comment.
npm ci requires a lockfile (e.g., package-lock.json/npm-shrinkwrap.json) and will fail if only package.json exists. Consider gating this step on the presence of a lockfile (or falling back to npm install) to keep CI deterministic but not brittle.
| if: hashFiles('package.json') != '' | |
| if: hashFiles('package-lock.json') != '' || hashFiles('npm-shrinkwrap.json') != '' | |
| - run: npm install | |
| if: hashFiles('package.json') != '' && hashFiles('package-lock.json') == '' && hashFiles('npm-shrinkwrap.json') == '' |
| issue_number: context.issue.number, | ||
| body: summary | ||
| }); | ||
| - run: npm run lint --if-present |
There was a problem hiding this comment.
The previous CI invoked npm run type-check, but this workflow runs npm run typecheck. With --if-present, this can silently skip type checking if the repository script is still named type-check, reducing CI coverage. Align the script name with what the repo defines (e.g., run type-check) or run both explicitly.
| - run: npm run lint --if-present | |
| - run: npm run lint --if-present | |
| - run: npm run type-check --if-present |
|
Removes unsafe automation. Adds deterministic CI. Ensures env placeholder. Non-destructive.