fix: add 'ducklake prefix if not present#4941
Merged
Conversation
themisvaltinos
approved these changes
Jul 9, 2025
Contributor
themisvaltinos
left a comment
themisvaltinos
left a comment
There was a problem hiding this comment.
should we maybe also update the docs/integrations/engines/duckdb.md docs to have in the ducklake examples the prefix
tobymao
approved these changes
Jul 9, 2025
Collaborator
Author
Now with this change I think we can leave it as is. That would have been useful in previous PR though (if I had known users weren't defining it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4913
Documentation consistently shows including
'ducklakein the path: https://ducklake.select/docs/stable/duckdb/usage/choosing_a_catalog_databaseIt seems like if you exclude it from the path but included the type then it would also work. If you include both though you would get an error. Therefore since the last PR excluded it from TYPE we had some users not include it in the path and had an error.
This PR ensures the
'ducklakeprefix is always there if the type of "ducklake" is provided.