Chore: Info instead of warn for conditional properties assignment#5122
Merged
themisvaltinos merged 1 commit intomainfrom Aug 11, 2025
Merged
Chore: Info instead of warn for conditional properties assignment#5122themisvaltinos merged 1 commit intomainfrom
themisvaltinos merged 1 commit intomainfrom
Conversation
georgesittas
approved these changes
Aug 11, 2025
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
LGTM, thank you.
Just to share some context, the rationale behind this change was that None and NULL are valid values that are used for conditional property rendering, so warning about them is too noisy and there is no clear action for the user to silence that warning, despite these values being intentionally used on their end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use info in the logs instead of warning for cases where a property is conditionally assigned.