Skip to content

Chore: Info instead of warn for conditional properties assignment #5122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themisvaltinos merged 1 commit into from
Aug 11, 2025
Merged

Chore: Info instead of warn for conditional properties assignment #5122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sqlmesh/core/model/definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,10 +681,10 @@ def _render(expression: exp.Expression) -> exp.Expression | None:
# in turn makes @this_model available in the evaluation context
rendered_exprs = self._statement_renderer(expression).render(**render_kwargs)

# Warn instead of raising for cases where a property is conditionally assigned
# Inform instead of raising for cases where a property is conditionally assigned
if not rendered_exprs or rendered_exprs[0].sql().lower() in {"none", "null"}:
logger.warning(
f"Expected rendering '{expression.sql(dialect=self.dialect)}' to return an expression"
logger.info(
f"Rendering '{expression.sql(dialect=self.dialect)}' did not return an expression"
)
return None

Expand Down