Merged
Conversation
erindru
reviewed
Aug 20, 2025
| assert len(plan_1.internal_schema_metadata.tables) == 1 | ||
|
|
||
| assert plan_1.table_name_for(model_a) in plan_1.internal_schema_metadata.tables | ||
| assert plan_1.dev_table_name_for(model_a) in plan_1.internal_schema_metadata.tables |
Collaborator
There was a problem hiding this comment.
I think this is correct if dev previews are no longer created "just in case" and are only created when needed
izeigerman
force-pushed
the
fix-snowflake-int-tests
branch
from
d327f07 to
926b9cc
Compare
erindru
approved these changes
Aug 20, 2025
izeigerman
force-pushed
the
fix-snowflake-int-tests
branch
from
aad5500 to
f93eb39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.