Skip to content

Fix snowflake int tests #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izeigerman merged 4 commits into from
Aug 21, 2025
Merged

Fix snowflake int tests #5198

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70fee96
Fix: Snowflake integration tests
izeigerman Aug 20, 2025
9412bf2
temporarily enable cloud integration tests
izeigerman Aug 20, 2025
becdfdc
only quote for snowflake
izeigerman Aug 20, 2025
f93eb39
Revert "temporarily enable cloud integration tests"
izeigerman Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/core/engine_adapter/integration/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import pytz
from sqlglot import exp, parse_one
from sqlglot.optimizer.normalize_identifiers import normalize_identifiers
from sqlglot.optimizer.qualify_columns import quote_identifiers

from sqlmesh import Config, Context
from sqlmesh.cli.project_init import init_example_project
Expand Down Expand Up @@ -1954,11 +1955,18 @@ def test_sushi(ctx: TestContext, tmp_path_factory: pytest.TempPathFactory):
],
personal_paths=[pathlib.Path("~/.sqlmesh/config.yaml").expanduser()],
)
config.before_all = [
before_all = [
f"CREATE SCHEMA IF NOT EXISTS {raw_test_schema}",
f"DROP VIEW IF EXISTS {raw_test_schema}.demographics",
f"CREATE VIEW {raw_test_schema}.demographics AS (SELECT 1 AS customer_id, '00000' AS zip)",
]
config.before_all = [
quote_identifiers(
parse_one(e, dialect=config.model_defaults.dialect),
dialect=config.model_defaults.dialect,
).sql(dialect=config.model_defaults.dialect)
for e in before_all
]

# To enable parallelism in integration tests
config.gateways = {ctx.gateway: config.gateways[ctx.gateway]}
Expand Down Expand Up @@ -2883,16 +2891,12 @@ def _run_plan(sqlmesh_context: Context, environment: str = None) -> PlanResults:
assert plan_1.snapshot_for(model_a).model.view_name in plan_1.schema_metadata.views
assert plan_1.snapshot_for(model_b).model.view_name in plan_1.schema_metadata.views

assert len(plan_1.internal_schema_metadata.tables) == 3
assert len(plan_1.internal_schema_metadata.tables) == 1

assert plan_1.table_name_for(model_a) in plan_1.internal_schema_metadata.tables
assert plan_1.dev_table_name_for(model_a) in plan_1.internal_schema_metadata.tables
Copy link
Collaborator

@erindru erindru Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct if dev previews are no longer created "just in case" and are only created when needed

assert (
plan_1.table_name_for(model_b) not in plan_1.internal_schema_metadata.tables
) # because its a managed table
assert (
plan_1.dev_table_name_for(model_b) in plan_1.internal_schema_metadata.tables
) # its dev table is a normal table however

assert len(plan_1.internal_schema_metadata.managed_tables) == 1
assert plan_1.table_name_for(model_b) in plan_1.internal_schema_metadata.managed_tables
Expand Down