[Feature] Improve type safety by using react-router generated route specific types#65
Open
k-melnychuk wants to merge 1 commit intoShopify:mainfrom
Open
[Feature] Improve type safety by using react-router generated route specific types#65k-melnychuk wants to merge 1 commit intoShopify:mainfrom
k-melnychuk wants to merge 1 commit intoShopify:mainfrom
Conversation
Contributor
Author
|
I have signed the CLA! |
3 tasks
k-melnychuk
force-pushed
the
feature/route-types
branch
from
0273e16 to
35c3e0a
Compare
Contributor
Author
|
@byrichardpowell @lizkenyon can this PR be looked at and merged in please? 😊 it’ll be nice to merge this in so that the auth middleware can get moving as well 🥹 |
k-melnychuk
force-pushed
the
feature/route-types
branch
from
35c3e0a to
7349ef4
Compare
Contributor
Author
|
Hey @byrichardpowell 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves type safety by replacing generic LoaderFunctionArgs (and similar types) with route-specific types generated by React Router.
Why
Checklist
README.mdfile and other related documentation, if applicableCHANGELOG.md