tweak(gui): Decouple GUI transition and world animation timing from render update #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

bobtista wants to merge 2 commits into TheSuperHackers:main from bobtista:bobtista/fix-gui-animation-timing

+20 −6

bobtista commented Jan 4, 2026

Summary

GUI window transitions now advance at a consistent rate regardless of frame rate
2D world animation icons (healing, promotion, crate collection effects) rise at consistent speed regardless of frame rate

Changes

TransitionGroup::m_currentFrame changed from Int to Real to support fractional frame accumulation
TransitionGroup::update() scales frame advancement by TheFramePacer->getActualLogicTimeScaleOverFpsRatio()
InGameUI world animation Z-rise calculation now scales by the same time factor

Test plan

Verify GUI transitions (menu fades, button flashes) play at the same speed at 30fps and higher frame rates
Verify 2D world icons (healing icons, veteran stars, crate pickups) rise at consistent speed regardless of frame rate

bobtista added 2 commits

January 3, 2026 21:46


          Decouple GUI transition and world animation timing from render update

a33c8d6


          Replicate to generals

1b3e8ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet