bugfix(system): Update crash message #2069
Conversation
JohnsterID
force-pushed
the
improve-crash-message
branch
from
ef722a3 to
24d2f11
Compare
| #ifdef RTS_ENABLE_CRASHDUMP | ||
| "\nMinidump files saved to:\n%s\n" | ||
| #endif | ||
| "\nPlease report the issue:\nhttps://github.com/TheSuperHackers/GeneralsGameCode/issues", |
There was a problem hiding this comment.
I do not think this prompt is wise. We might get bombarded with messages. Maybe there should be a separate repository where players can spam reports. For GeneralsGameCode we would like to keep more quality reports by developers for developers.
| ); | ||
| } else { | ||
| snprintf(buff, sizeof(buff), | ||
| "The game encountered a critical error and needs to close.\n\n" |
There was a problem hiding this comment.
There are now 4 error messages here in code. Why is this so complicated? Can the code be simplified and reduced to one error message to rule them all?
| } | ||
|
|
||
| // TheSuperHackers @bugfix JohnsterID 06/01/2025 Append crash file locations to localized error message | ||
| char crashInfoPath[_MAX_PATH]; |
There was a problem hiding this comment.
Maybe the Debug and Release crash message boxes can reuse the same code, or do they need to be separate?
| strlcat(crashDumpDir, "CrashDumps\\", ARRAY_SIZE(crashDumpDir)); | ||
| #endif | ||
|
|
||
| // Extract first line of stack trace (crash location) if available |
There was a problem hiding this comment.
Perhaps the stack trace stuff can be moved into separate function to clean this up.
For example
callstack[512]
writeCallstack(callstack, ARRAY_SIZE(callstack));2 participants
No description provided.