Fix generation error #737
Merged
Fix generation error #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPColin
approved these changes
Jan 25, 2026
Collaborator
|
Oh that difference between |
Member
|
In hindsight, maybe I should've asked about that change in the previous PR… Sounds like a classic case of overzealous analyzers. Edit: looking at the full code, I guess we explicitly don't care about how many bytes were read, because rom (banks) have a specific, fixed size that should be padded with zeroes? |
Vivelin
approved these changes
Jan 25, 2026
Collaborator
Author
Yeah, that's my guess. At the point, it's like 5+ year old code that pre-dates Cas', so just feels best to leave it be. lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let this be a lesson to just ignore IDE warnings coming from GitHub actions! :) Or maybe to just test last minute changes to remove those warnings...