Skip to content

Fix generation error #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattEqualsCoder merged 1 commit into from
Jan 25, 2026
Merged

Fix generation error #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/TrackerCouncil.Smz3.SeedGenerator/FileData/Rom.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,23 @@ public static byte[] CombineSMZ3Rom(Stream smRom, Stream z3Rom)
pos = 0;
for (var i = 0; i < 0x40; i++)
{
smRom.ReadExactly(combined, pos + 0x8000, 0x8000);
_ = smRom.Read(combined, pos + 0x8000, 0x8000);
pos += 0x10000;
}

/* SM lo bank */
pos = 0;
for (var i = 0; i < 0x40; i++)
{
smRom.ReadExactly(combined, pos, 0x8000);
_ = smRom.Read(combined, pos, 0x8000);
pos += 0x10000;
}

/* Z3 hi bank*/
pos = 0x400000;
for (var i = 0; i < 0x20; i++)
{
z3Rom.ReadExactly(combined, pos + 0x8000, 0x8000);
_ = z3Rom.Read(combined, pos + 0x8000, 0x8000);
pos += 0x10000;
}

Expand All @@ -42,7 +42,7 @@ public static byte[] CombineSMZ3Rom(Stream smRom, Stream z3Rom)
public static byte[] ExpandRom(Stream rom, int size)
{
var expanded = new byte[size];
rom.ReadExactly(expanded, 0, size);
_ = rom.Read(expanded, 0, size);
return expanded;
}

Expand Down Expand Up @@ -83,7 +83,7 @@ public static void ApplyIps(byte[] rom, Stream ips, Func<int, int> translateOffs
var size = (ips.ReadByte() << 8) | ips.ReadByte();
if (size > 0)
{
ips.ReadExactly(rom, translateOffset(offset), size);
_ = ips.Read(rom, translateOffset(offset), size);
}
else
{
Expand Down