Closed
Conversation
I’ve made the base determination more efficient by using logs to determine how many times 1000 divides into number There’s now an array of suffixes that you can add to at will Added a primitive domCache to the system. Instead of using document.getElementById you should now use gameElements.getElementById This builds a cache on the fly and returns from that. I can’t recommend enough that jQuery (or some other similar library) be used for this instead; it’s a lot more robust than what I cobbled together and has more efficiency programming done.
Had messed up numbers less than 1
… to the console if there's a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a gameElements object literal which contains a node object literal and a function getElementById which works almost identically to document.getElementById except it caches.
jQuery handles this stuff in a much more robust manner, but this should do in a pinch.
I've also made some dramatic changes to the prettify function you might want to look over.