Skip to content

Add more RobotAPI commands to PolyScope X Dashboard Client#435

Open
urfeex wants to merge 17 commits intoUniversalRobots:masterfrom
urfeex:dashboard_x_new_commands
Open

Add more RobotAPI commands to PolyScope X Dashboard Client#435
urfeex wants to merge 17 commits intoUniversalRobots:masterfrom
urfeex:dashboard_x_new_commands

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Feb 12, 2026

This adds the endpoints as added in PolyScope 10.12.0

urfeex and others added 8 commits February 12, 2026 13:18
Added
  - is_in_remote_control
  - robot_mode
  - safety_mode
  - operational_mode
The trailing / in 10.11.0 was an error which has been fixed later.
Squashed commit of the following:

commit 7fa40d1427e36069ef93caaed136351fc810afda
Author: Jacob Larsen <jala@universal-robots.com>
Date:   Fri Jan 23 13:39:49 2026 +0000

    Make tests version sensitive and implement suggestions

commit ea3d8a3b263d983cf614c60575a81c8da08574b4
Author: Jacob Larsen <jala@universal-robots.com>
Date:   Wed Jan 21 14:45:33 2026 +0000

    Add tests for get_x dashboard calls
@urfeex urfeex requested a review from a team February 12, 2026 12:20
@urfeex urfeex added the enhancement New feature or request label Feb 12, 2026
@urfeex urfeex linked an issue Feb 12, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 2.85714% with 170 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.10%. Comparing base (08c33c3) to head (1541b4a).

Files with missing lines Patch % Lines
src/ur/dashboard_client_implementation_x.cpp 3.47% 136 Missing and 3 partials ⚠️
src/ur/dashboard_client_implementation_g5.cpp 0.00% 12 Missing ⚠️
...lient_library/ur/dashboard_client_implementation.h 0.00% 9 Missing ⚠️
src/ur/dashboard_client.cpp 0.00% 8 Missing ⚠️
include/ur_client_library/ur/dashboard_client.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   75.33%   73.10%   -2.23%     
==========================================
  Files         102      102              
  Lines        5120     5269     +149     
  Branches      544      566      +22     
==========================================
- Hits         3857     3852       -5     
- Misses        980     1130     +150     
- Partials      283      287       +4     
Flag Coverage Δ
start_ursim 82.59% <ø> (-2.03%) ⬇️
ur5-3.14.3 70.91% <0.00%> (-2.38%) ⬇️
ur5e-10.11.0 63.72% <2.89%> (?)
ur5e-10.12.0 63.72% <2.89%> (?)
ur5e-10.7.0 63.07% <0.00%> (-2.24%) ⬇️
ur5e-5.9.4 71.19% <0.00%> (-2.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 795 to 807
/*!
* \brief Sets the polyscope version manually.
*
* If the dashboard client implementation is not able to query the version from the robot
* automatically, this function can be used to set it manually.
*
* \param version The version string as returned by the robot
*/
void setPolyscopeVersion(const VersionInformation& version)
{
polyscope_version_ = version;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard client itself doesn't necessarily know its version (at least on PolyScope X). With this, we can query the version elsewhere (e.g. the primary interface) and let the Robot API client know which version it is running on.

Setting the PolyScope version helps making version-dependent calls
@urfeex urfeex requested a review from urrsk February 13, 2026 08:27
@urfeex urfeex force-pushed the dashboard_x_new_commands branch from d67f8dd to 1cdae9e Compare February 13, 2026 13:25
@urfeex urfeex force-pushed the dashboard_x_new_commands branch from 1d7b659 to 1541b4a Compare February 13, 2026 14:07
This was referenced Feb 13, 2026
@urfeex urfeex linked an issue Feb 13, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polyscope X Dashboard doesn't follow redirects Add New Robot API Calls

3 participants