fix: have technique management page default to most recent active call#1357
Open
ellen-wright wants to merge 18 commits intodevelopfrom
Open
fix: have technique management page default to most recent active call#1357ellen-wright wants to merge 18 commits intodevelopfrom
ellen-wright wants to merge 18 commits intodevelopfrom
Conversation
ellen-wright
requested review from
a team,
EdwardHaynes,
martin-trajanovski and
yoganandaness
and removed request for
a team and
martin-trajanovski
ellen-wright
changed the title
…lt-to-newest-active-call
TCMeldrum
approved these changes
Feb 17, 2026
yoganandaness
requested changes
Feb 17, 2026
| ).calls; | ||
|
|
||
| const openCall = calls?.find((call) => call.isActive); | ||
| const sortedcalls = calls.sort((a, b) => (a.id > b.id ? -1 : 1)); |
Contributor
There was a problem hiding this comment.
Should we take it to the backend instead of frontend?
Contributor
There was a problem hiding this comment.
Also recommending unit tests and e2e, as necessary
…lt-to-newest-active-call
…ctive-call' of https://github.com/UserOfficeProject/user-office-core into 1521-Make-technique-management-page-default-to-newest-active-call
…lt-to-newest-active-call
yoganandaness
requested changes
Feb 19, 2026
|
|
||
| @Field(() => Boolean, { nullable: true }) | ||
| public isOrdered?: boolean; | ||
| @Field(() => String, { nullable: true }) |
Contributor
There was a problem hiding this comment.
This is great, still slightly deviating from other places.
Recommending to follow this approach as we have the same in most other places
- Letting the sortField and sortDirection open as string could result in sql injection error. This is the reason, we want to use PaginationSortDirection
Note: The term pagination is misleading, as this can be used for non pagination entities like here in calls
2. I would recommend sort outside the filter object, since filter is more subject oriented to call and sort is quite generic. It also aligns with the other implementations as well(Proposals, Experiments, Users, Questions etc., )
| ...getFilterStatus(callStatus as CallStatusFilters, isArchivedTab), | ||
| isOrdered: true, | ||
| sortField: 'sort_order', | ||
| sortDirection: 'asc', |
Contributor
There was a problem hiding this comment.
Suggested change
| sortDirection: 'asc', | |
| sortDirection: PaginationSortDirection.asc, |
| { | ||
| proposalStatusShortCode: 'QUICK_REVIEW', | ||
| sortField: 'call_id', | ||
| sortDirection: 'desc', |
Contributor
There was a problem hiding this comment.
Suggested change
| sortDirection: 'desc', | |
| sortDirection: PaginationSortDirection.desc, |
| isActiveInternal: isInternalUser, | ||
| isOrdered: true, | ||
| sortField: 'sort_order', | ||
| sortDirection: 'asc', |
Contributor
There was a problem hiding this comment.
Suggested change
| sortDirection: 'asc', | |
| sortDirection: PaginationSortDirection.asc, |
…ctive-call' of https://github.com/UserOfficeProject/user-office-core into 1521-Make-technique-management-page-default-to-newest-active-call
…lt-to-newest-active-call
…lt-to-newest-active-call
…lt-to-newest-active-call
2 tasks
…lt-to-newest-active-call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refs: UserOfficeProject/issue-tracker#1521
Sets the default call filter in technique management page to be the newest active call.
Motivation and Context
We have a bug where the call filter is still defaulting to the previous technique call instead of moving over to the newly created one for the new year.
This PR sets the URL parameter as the active call with the highest call_id which will be the newest technique call and therefore as there is only one technique call open all year the relevant one will be the default.
How Has This Been Tested
Fixes
Changes
Depends on
Tests included/Docs Updated?