Skip to content

correct docstring for Value::isString #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tnovotny wants to merge 2 commits into
base: master
Choose a base branch
from
Open

correct docstring for Value::isString #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a9128b
correct docstring for Value::isString
tnovotny Sep 10, 2017
cbf2ba1
add #include <iso646.h> so it compiles with microsoft compiler
tnovotny Sep 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
#ifndef TYPES_HPP
#define TYPES_HPP

#include <iso646.h>

namespace ubjson {

using byte = unsigned char;
Expand Down
4 changes: 3 additions & 1 deletion include/value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
#include <unordered_map>
#include <map>
#include <initializer_list>
#include <iso646.h>
Copy link
Owner

@WhiZTiM WhiZTiM Sep 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably superfluous, since #include <iso646.h> already included in types.hpp which is included in this file. See line 55


#include "exception.hpp"
#include "iterator.hpp"
#include "types.hpp"
Expand Down Expand Up @@ -285,7 +287,7 @@ namespace ubjson {
//! Returns whether the contained type is a floating point type (double)
bool isFloat() const noexcept;

//! Returns whether the contained type is a floating point type. (double)
//! Returns whether the contained type is \ref ArrayType "Array"
bool isArray() const noexcept;

//! The same thing as \ref isMap()
Expand Down
2 changes: 2 additions & 0 deletions src/value.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@


#include "value.hpp"

#include <cmath>
#include <limits>
#include <cstring>
#include <algorithm>
#include <iostream>
#include <iso646.h>
Copy link
Owner

@WhiZTiM WhiZTiM Sep 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here,...


using namespace ubjson;

Expand Down