Skip to content

Added ability to ignore tags when deleting packages#104

Open
Hayena wants to merge 2 commits intoactions:mainfrom
port-of-rotterdam-dtis:include-tags-ignore-version
Open

Added ability to ignore tags when deleting packages#104
Hayena wants to merge 2 commits intoactions:mainfrom
port-of-rotterdam-dtis:include-tags-ignore-version

Conversation

@Hayena
Copy link

@Hayena Hayena commented Apr 18, 2023

This PR contains a possible implementation for #88. This implementation adds a input parameter to enable ignoring of tags based on the existing ignore-versions input

@Hayena Hayena requested a review from a team as a code owner April 18, 2023 14:54
@Hayena Hayena force-pushed the include-tags-ignore-version branch from 0dcd581 to bf25fb8 Compare April 18, 2023 15:02
@Sxderp
Copy link

Sxderp commented May 1, 2023

The inverse of this would also be very nice. "Delete only these tags".

@cjmayo cjmayo mentioned this pull request May 16, 2023
Closed
@johammond9
Copy link

johammond9 commented Jun 12, 2023

This would be a very helpful for maintaining container packages. Would be great if we can get a reviewer!

@Marwel Marwel mentioned this pull request Sep 14, 2023
Closed
@UnderKoen
Copy link

UnderKoen commented Jan 18, 2024

Any plans on merging this PR?

@jidicula

@AtomicFS
Copy link

AtomicFS commented Feb 21, 2024

What is the status? This would be great!

@AtomicFS AtomicFS mentioned this pull request Feb 21, 2024
Open
AtomicFS added a commit to 9elements/firmware-action that referenced this pull request Feb 28, 2024
@AtomicFS
ci: delete old packages
4d9d50d 
- add a step in docker-build-and-test to delete old published containers
- should delete all but 'main', 'latest' and release containers
- we have to use my own fork of actions/delete-package-versions
  at the moment to have access to 'dry-run' and
  'ignore-versions-include-tags' features
- [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits)
- [tags](actions/delete-package-versions#104)

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
@AtomicFS AtomicFS mentioned this pull request Feb 28, 2024
Merged
AtomicFS added a commit to 9elements/firmware-action that referenced this pull request Feb 29, 2024
@AtomicFS
ci: delete old packages
8e7c64c 
- add a step in docker-build-and-test to delete old published containers
- should delete all but 'main', 'latest' and release containers
- we have to use my own fork of actions/delete-package-versions
  at the moment to have access to 'dry-run' and
  'ignore-versions-include-tags' features
- [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits)
- [tags](actions/delete-package-versions#104)

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
AtomicFS added a commit to 9elements/firmware-action that referenced this pull request Mar 1, 2024
@AtomicFS
ci: delete old packages
05f2d97 
- add a step in docker-build-and-test to delete old published containers
- should delete all but 'main', 'latest' and release containers
- we have to use my own fork of actions/delete-package-versions
  at the moment to have access to 'dry-run' and
  'ignore-versions-include-tags' features
- [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits)
- [tags](actions/delete-package-versions#104)

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
github-merge-queue bot pushed a commit to 9elements/firmware-action that referenced this pull request Mar 4, 2024
@AtomicFS
ci: delete old packages
7ba262a 
- add a step in docker-build-and-test to delete old published containers
- should delete all but 'main', 'latest' and release containers
- we have to use my own fork of actions/delete-package-versions
  at the moment to have access to 'dry-run' and
  'ignore-versions-include-tags' features
- [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits)
- [tags](actions/delete-package-versions#104)

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
AtomicFS added a commit to 9elements/firmware-action that referenced this pull request Mar 4, 2024
@AtomicFS
ci: delete old packages
c169a50 
- add a step in docker-build-and-test to delete old published containers
- should delete all but 'main', 'latest' and release containers
- we have to use my own fork of actions/delete-package-versions
  at the moment to have access to 'dry-run' and
  'ignore-versions-include-tags' features
- [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits)
- [tags](actions/delete-package-versions#104)

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
github-merge-queue bot pushed a commit to 9elements/firmware-action that referenced this pull request Mar 4, 2024
@AtomicFS
ci: delete old packages
d49be74 
- add a step in docker-build-and-test to delete old published containers
- should delete all but 'main', 'latest' and release containers
- we have to use my own fork of actions/delete-package-versions
  at the moment to have access to 'dry-run' and
  'ignore-versions-include-tags' features
- [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits)
- [tags](actions/delete-package-versions#104)

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
davidfevre-gouv-nc
davidfevre-gouv-nc reviewed May 29, 2024
View reviewed changes
@Hayena @davidfevre-gouv-nc
Update README.md
d20ee9a 
Co-authored-by: David Fèvre <62677553+davidfevre-gouv-nc@users.noreply.github.com>
@gurugray
Copy link

gurugray commented Jul 9, 2024

this feature would be very useful

cc @jidicula

@jidicula
Copy link
Contributor

jidicula commented Jul 23, 2024

this feature would be very useful

cc @jidicula

👋 hey @gurugray, I no longer work on this part of GitHub 🙂

@AtomicFS
Copy link

AtomicFS commented Aug 2, 2024

@davidfevre-gouv-nc any chance of getting this merged?

@rbtr
Copy link

rbtr commented Aug 2, 2024

👋 hey @gurugray, I no longer work on this part of GitHub 🙂

@jidicula so could you tag someone who does? or is this abandoned?

@jidicula
Copy link
Contributor

jidicula commented Aug 2, 2024

👋 hey @gurugray, I no longer work on this part of GitHub 🙂

@jidicula so could you tag someone who does? or is this abandoned?

👍 I've pinged the relevant team.

@davidfevre-gouv-nc
Copy link

davidfevre-gouv-nc commented Aug 4, 2024

@davidfevre-gouv-nc any chance of getting this merged?

Hi @AtomicFS, I added my code review to mark my interest in this feature but I am not part of the CODEOWNERS, so not able to merge 😞

@AtomicFS
Copy link

AtomicFS commented Aug 5, 2024

@davidfevre-gouv-nc Oh I see, sorry for the unnecessary ping.

@andrinbr
Copy link

andrinbr commented Jan 28, 2025

Any updates on this? Would be great if it could be merged.

@davidfevre-gouv-nc
Copy link

davidfevre-gouv-nc commented Jan 28, 2025

Maybe @conorsloan could help ?

By the way, I now use vlaurin/action-ghcr-prune.

@emmahsax
Copy link

emmahsax commented Feb 4, 2025

I am also watching this issue to see how it does.

FWIW, I use emmahsax/action-ghcr-prune (which is a fork of a fork of vlaurin's version).

@JulianBerger
Copy link

JulianBerger commented May 27, 2025

Can we merge this?

@AtomicFS AtomicFS mentioned this pull request Aug 1, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davidfevre-gouv-nc davidfevre-gouv-nc davidfevre-gouv-nc approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments