Add getDefaultInitInfo option in run command#91
Open
jonsnyder wants to merge 5 commits intoadobe:masterfrom
Open
Add getDefaultInitInfo option in run command#91jonsnyder wants to merge 5 commits intoadobe:masterfrom
jonsnyder wants to merge 5 commits intoadobe:masterfrom
Conversation
9 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new api endpoint "/defaultInitInfo/:type/:name" which returns the default init info for a component. This api endpoint calls a user specified callback to modify the initInfo,
getDefaultInitInfo. This is useful for generating and setting an access token or setting up custom defaults for extensionSettings or other properties in the initInfo.Related Issue
Motivation and Context
I got tired of manually adding an access token and IMS orgId when developing the Tags extension for AEP Web SDK. Also we have a drop down that gets data from the extensionSettings part of initInfo to select the Alloy instance. This errors out when the extensionSettings is
{"foo": "bar }.This change will save our team lots of time and frustration as before now we have had to copy and paste tokens, and remember how to get the instance name picker to work.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: