-
-
Notifications
You must be signed in to change notification settings - Fork 280
Pass keyword arguments to SQLAlchemy relationships in SQLModel relationships #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #376. # Conflicts: # CHANGES.rst # Conflicts: # CHANGES.rst # Conflicts: # CHANGES.rst
sheinbergon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added 2 comments that are mostly cosmetic. Juding by the test, looks like it does what it's supposed to do. Very nice code cleanup
Approved. Do with the comments as you see fit
sheinbergon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just put the new changes in their own dedicated block
sheinbergon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved again. Resolve the comments as you see fit
|
I could do another PR for that migration away from |
Sounds great. |
|
I hit a wrinkle: |
|
I guess they must've made it work since Python 3.14 has that on by default. |
|
Yeah, this is a no go: |
|
One would think this stupid issue had been fixed by now but I guess not. |
Well, you gave it a try |
|
Did you want to get something else into the final release? |
I wanted to run a manual test on the enum arrays before proceeding to 4.0.0 GA. I'll get to it today / tomorrow, and we can proceed to the final release |
Changes
Fixes #376.
Refactors the API in such a way that lets the SQLModel code generator pass relationship arguments to the underlying SQLAlchemy
relationship.Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.