Ensure the transaction has succeeded before indexing or removing objects#385
Open
lemonlab wants to merge 2 commits intoalgolia:masterfrom
Open
Ensure the transaction has succeeded before indexing or removing objects#385lemonlab wants to merge 2 commits intoalgolia:masterfrom
lemonlab wants to merge 2 commits intoalgolia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Index and remove objects during the
postFlushevent to ensure the transaction has succeeded.What problem is this fixing?
The
postUpdateandpostPersistevents are triggered after the database operations on entity data but before the transaction has been committed.https://www.doctrine-project.org/projects/doctrine-orm/en/3.3/reference/events.html#postupdate-postremove-postpersist
If the transaction fails, the object could be indexed in Algolia without the corresponding database change, causing desynchronization between the database and Algolia. By indexing or removing objects in the
postFlushevent, we ensure that the transaction has succeeded first.