Skip to content

Ensure the transaction has succeeded before indexing or removing objects #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lemonlab wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure the transaction has succeeded before indexing or removing objects #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
372746c
Make sure transaction succeeded before indexing/removing objects
lemonlab Oct 29, 2024
5ceb5d8
CS fix
lemonlab Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions src/EventListener/SearchIndexerSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,43 +3,46 @@
namespace Algolia\SearchBundle\EventListener;

use Algolia\SearchBundle\SearchService;
use Doctrine\ORM\Event\PostFlushEventArgs;
use Doctrine\ORM\Event\PostPersistEventArgs;
use Doctrine\ORM\Event\PostUpdateEventArgs;
use Doctrine\ORM\Event\PreRemoveEventArgs;

class SearchIndexerSubscriber
{
/**
* @var SearchService
*/
private $searchService;
private array $objectsToIndex = [];
private array $objectsToRemove = [];

public function __construct(SearchService $searchService)
public function __construct(
private readonly SearchService $searchService,
) {
}

public function postPersist(PostPersistEventArgs $args): void
{
$this->searchService = $searchService;
$this->objectsToIndex[] = $args->getObject();
}

/**
* @return void
*/
public function postPersist(PostPersistEventArgs $args)
public function postUpdate(PostUpdateEventArgs $args): void
{
$this->searchService->index($args->getObjectManager(), $args->getObject());
$this->objectsToIndex[] = $args->getObject();
}

/**
* @return void
*/
public function postUpdate(PostUpdateEventArgs $args)
public function preRemove(PreRemoveEventArgs $args): void
{
$this->searchService->index($args->getObjectManager(), $args->getObject());
$this->objectsToRemove[] = $args->getObject();
}

/**
* @return void
*/
public function preRemove(PreRemoveEventArgs $args)
public function postFlush(PostFlushEventArgs $args): void
{
$this->searchService->remove($args->getObjectManager(), $object = $args->getObject());
foreach ($this->objectsToIndex as $object) {
$this->searchService->index($args->getObjectManager(), $object);
}
$this->objectsToIndex = [];

foreach ($this->objectsToRemove as $object) {
$this->searchService->remove($args->getObjectManager(), $object);
}
$this->objectsToRemove = [];
}
}