clean up initial conditions to ensure directive is applied on page load as well as resize#7
Open
furiousOyster wants to merge 4 commits intoanthonychu:masterfrom
furiousOyster:master
Open
clean up initial conditions to ensure directive is applied on page load as well as resize#7furiousOyster wants to merge 4 commits intoanthonychu:masterfrom furiousOyster:master
furiousOyster wants to merge 4 commits intoanthonychu:masterfrom
furiousOyster:master
Conversation
added 4 commits
December 3, 2015 12:11
run once on document load properly.
Author
|
doesn't run on pageload in circumstances where element is created by ng-repeat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, directive does not seem to apply in some cases on first page load.
Directive is loaded before the page has finished loading, so first call to onWindowResize fails to set size correctly.
Also no need for debounce on page load.