Skip to content

clean up initial conditions to ensure directive is applied on page load as well as resize #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
furiousOyster wants to merge 4 commits into
base: master
Choose a base branch
from
Open

clean up initial conditions to ensure directive is applied on page load as well as resize #7

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df0512d
fill height on initial load
Dec 3, 2015
62cbd13
cleaner initial conditions
Dec 3, 2015
86e8c20
load error fix
Dec 3, 2015
8f32fd1
rename function to work with debounce.
Dec 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/fill-height.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@
},
link: function (scope, element, attrs) {
if (scope.debounceWait === 0) {
angular.element($window).on('resize', windowResize);
angular.element($window).on('resize', onWindowResize);
} else {
// allow debounce wait time to be passed in.
// if not passed in, default to a reasonable 250ms
angular.element($window).on('resize', debounce(onWindowResize, scope.debounceWait || 250));
}

onWindowResize();

//call once the DOM is ready
$timeout(onWindowResize);

// returns a fn that will trigger 'time' amount after it stops getting called.
function debounce(fn, time) {
var timeout;
Expand Down Expand Up @@ -59,7 +60,7 @@
- footerElementHeight
- additionalPadding;

console.log(elementHeight);
//console.info(elementHeight);
element.css('height', elementHeight + 'px');
}

Expand Down